Skip to content

Commit cca23b4

Browse files
committed
fix(mac): throw sign error correctly
Closes #737
1 parent 49ec5fd commit cca23b4

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@
7171
"cuint": "^0.2.2",
7272
"debug": "^2.2.0",
7373
"electron-download": "2.1.2",
74-
"electron-osx-sign": "^0.4.0-beta4",
74+
"electron-osx-sign-tf": "^1.0.0",
7575
"extract-zip": "^1.5.0",
7676
"fs-extra-p": "^1.1.8",
7777
"hosted-git-info": "^2.1.5",

src/macPackager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { Promise as BluebirdPromise } from "bluebird"
66
import { log, warn, task } from "./util/log"
77
import { createKeychain, CodeSigningInfo, findIdentity } from "./codeSign"
88
import { deepAssign } from "./util/deepAssign"
9-
import { signAsync, flatAsync, BaseSignOptions, SignOptions, FlatOptions } from "electron-osx-sign"
9+
import { signAsync, flatAsync, BaseSignOptions, SignOptions, FlatOptions } from "electron-osx-sign-tf"
1010
import { DmgTarget } from "./targets/dmg"
1111
import { createCommonTarget, DEFAULT_TARGET } from "./targets/targetFactory"
1212
import { AppInfo } from "./appInfo"

test/src/globTest.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,16 +151,16 @@ test.ifNotCiOsx("ignore node_modules known dev dep", () => {
151151
return BluebirdPromise.all([
152152
modifyPackageJson(projectDir, data => {
153153
data.devDependencies = Object.assign({
154-
"electron-osx-sign": "*",
154+
"electron-osx-sign-tf": "*",
155155
}, data.devDependencies)
156156
}),
157-
outputFile(path.join(projectDir, "node_modules", "electron-osx-sign", "package.json"), "{}"),
157+
outputFile(path.join(projectDir, "node_modules", "electron-osx-sign-tf", "package.json"), "{}"),
158158
outputFile(path.join(projectDir, "ignoreMe"), ""),
159159
])
160160
},
161161
packed: context => {
162162
return BluebirdPromise.all([
163-
assertThat(path.join(context.getResources(Platform.LINUX), "app", "node_modules", "electron-osx-sign")).doesNotExist(),
163+
assertThat(path.join(context.getResources(Platform.LINUX), "app", "node_modules", "electron-osx-sign-tf")).doesNotExist(),
164164
assertThat(path.join(context.getResources(Platform.LINUX), "app", "ignoreMe")).doesNotExist(),
165165
])
166166
},

test/src/macPackagerTest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { BuildInfo } from "out/platformPackager"
77
import { Promise as BluebirdPromise } from "bluebird"
88
import { assertThat } from "./helpers/fileAssert"
99
import { Platform, MacOptions, createTargets } from "out"
10-
import { SignOptions, FlatOptions } from "electron-osx-sign"
10+
import { SignOptions, FlatOptions } from "electron-osx-sign-tf"
1111
import { Arch } from "out"
1212
import { Target } from "out/platformPackager"
1313
import { DmgTarget } from "out/targets/dmg"

test/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"../node_modules/ava-tf/types/generated.d.ts",
2323
"../node_modules/fs-extra-p/index.d.ts",
2424
"../node_modules/fs-extra-p/bluebird.d.ts",
25-
"../node_modules/electron-osx-sign/index.d.ts",
25+
"../node_modules/electron-osx-sign-tf/index.d.ts",
2626
"../node_modules/@types/**/*.d.ts"
2727
],
2828
"exclude": [

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"node_modules/fs-extra-p/index.d.ts",
2727
"node_modules/7zip-bin/index.d.ts",
2828
"node_modules/fs-extra-p/bluebird.d.ts",
29-
"node_modules/electron-osx-sign/index.d.ts",
29+
"node_modules/electron-osx-sign-tf/index.d.ts",
3030
"node_modules/@types/**/*.d.ts"
3131
],
3232
"exclude": [

0 commit comments

Comments
 (0)