fix: use lowercased safe artifact name if app name is lowercased

develar · develar · commit bfd6635134a8 · 2017-03-22T18:44:32.000+01:00
diff --git a/packages/electron-builder/src/targets/WebInstaller.ts b/packages/electron-builder/src/targets/WebInstaller.ts
@@ -39,6 +39,8 @@ export default class WebInstallerTarget extends NsisTarget {
   }
 
   protected generateGitHubInstallerName(): string {
-    return `${this.packager.appInfo.name}-WebSetup-${this.packager.appInfo.version}.exe`
+    const appInfo = this.packager.appInfo
+    const classifier = appInfo.name.toLowerCase() === appInfo.name ? "web-setup" : "WebSetup"
+    return `${appInfo.name}-${classifier}-${appInfo.version}.exe`
   }
 }
diff --git a/packages/electron-builder/src/targets/nsis.ts b/packages/electron-builder/src/targets/nsis.ts
@@ -180,7 +180,9 @@ export default class NsisTarget extends Target {
   }
 
   protected generateGitHubInstallerName() {
-    return `${this.packager.appInfo.name}-${this.isPortable ? "" : "Setup-"}${this.packager.appInfo.version}.exe`
+    const appInfo = this.packager.appInfo
+    const classifier = appInfo.name.toLowerCase() === appInfo.name ? "setup-" : "Setup-"
+    return `${appInfo.name}-${this.isPortable ? "" : classifier}${appInfo.version}.exe`
   }
 
   private get isUnicodeEnabled() {
diff --git a/test/out/windows/__snapshots__/installerTest.js.snap b/test/out/windows/__snapshots__/installerTest.js.snap
@@ -5,7 +5,7 @@ Object {
   "win": Array [
     Object {
       "file": "Test Custom Installation Dir Setup 1.1.0.exe",
-      "safeArtifactName": "test-custom-inst-dir-Setup-1.1.0.exe",
+      "safeArtifactName": "test-custom-inst-dir-setup-1.1.0.exe",
     },
   ],
 }
@@ -21,7 +21,7 @@ Object {
 
 exports[`allowToChangeInstallationDirectory 3`] = `
 Object {
-  "githubArtifactName": "test-custom-inst-dir-Setup-1.1.0.exe",
+  "githubArtifactName": "test-custom-inst-dir-setup-1.1.0.exe",
   "path": "Test Custom Installation Dir Setup 1.1.0.exe",
   "version": "1.1.0",
 }
diff --git a/test/out/windows/__snapshots__/oneClickInstallerTest.js.snap b/test/out/windows/__snapshots__/oneClickInstallerTest.js.snap
@@ -29,7 +29,7 @@ Object {
   "win": Array [
     Object {
       "file": "Test Menu Category CustomName 1.1.0.exe",
-      "safeArtifactName": "test-menu-category-Setup-1.1.0.exe",
+      "safeArtifactName": "test-menu-category-setup-1.1.0.exe",
     },
   ],
 }

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,8 @@ export default class WebInstallerTarget extends NsisTarget {`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`protected generateGitHubInstallerName(): string {`
`42`		- return `${this.packager.appInfo.name}-WebSetup-${this.packager.appInfo.version}.exe`
	`42`	`+ const appInfo = this.packager.appInfo`
	`43`	`+ const classifier = appInfo.name.toLowerCase() === appInfo.name ? "web-setup" : "WebSetup"`
	`44`	+ return `${appInfo.name}-${classifier}-${appInfo.version}.exe`
`43`	`45`	`}`
`44`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,9 @@ export default class NsisTarget extends Target {`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`protected generateGitHubInstallerName() {`
`183`		- return `${this.packager.appInfo.name}-${this.isPortable ? "" : "Setup-"}${this.packager.appInfo.version}.exe`
	`183`	`+ const appInfo = this.packager.appInfo`
	`184`	`+ const classifier = appInfo.name.toLowerCase() === appInfo.name ? "setup-" : "Setup-"`
	`185`	+ return `${appInfo.name}-${this.isPortable ? "" : classifier}${appInfo.version}.exe`
`184`	`186`	`}`
`185`	`187`
`186`	`188`	`private get isUnicodeEnabled() {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ Object {`
`29`	`29`	`"win": Array [`
`30`	`30`	`Object {`
`31`	`31`	`"file": "Test Menu Category CustomName 1.1.0.exe",`
`32`		`- "safeArtifactName": "test-menu-category-Setup-1.1.0.exe",`
	`32`	`+ "safeArtifactName": "test-menu-category-setup-1.1.0.exe",`
`33`	`33`	`},`
`34`	`34`	`],`
`35`	`35`	`}`