feat(snap): do not all apt-get install and update if build packages already installed

develar · develar · commit ba9e9da3587a · 2018-01-30T15:49:05.000-08:00
So, reduce risk that build will be failed because of sudo. Yes - snapcraft can also install build packages. But at least electron-builder doesn't fail.
diff --git a/packages/electron-builder-lib/src/targets/snap.ts b/packages/electron-builder-lib/src/targets/snap.ts
@@ -7,6 +7,7 @@ import { Target } from "../core"
 import { LinuxPackager } from "../linuxPackager"
 import { LinuxTargetHelper } from "./LinuxTargetHelper"
 import { createStageDir, StageDir } from "./targetUtil"
+import BluebirdPromise from "bluebird-lst"
 
 // usr/share/fonts is required, cannot run otherwise
 const unnecessaryFiles = [
@@ -110,8 +111,14 @@ export default class SnapTarget extends Target {
     }
     else {
       if (options.buildPackages != null && options.buildPackages.length > 0) {
-        await spawn("apt-get", ["-qq", "update"])
-        await spawn("apt-get", ["-qq", "install", "--no-install-recommends"].concat(options.buildPackages))
+        const notInstalledPackages = await BluebirdPromise.filter(options.buildPackages, (it): Promise<boolean> => {
+          return exec("dpkg", ["-s", it])
+            .then(result => result.includes("is not installed"))
+        })
+        if (notInstalledPackages.length > 0) {
+          await spawn("apt-get", ["-qq", "update"])
+          await spawn("apt-get", ["-qq", "install", "--no-install-recommends"].concat(notInstalledPackages))
+        }
       }
       const spawnOptions = {
         cwd: stageDir.dir,
@@ -156,4 +163,4 @@ export default class SnapTarget extends Target {
       stdio: ["ignore", "inherit", "inherit"],
     })
   }
-}
+}
