Skip to content

Commit ba2957e

Browse files
committed
fix(electron-updater): Nsis app from fall 2017 (electron-updater 2.10.0) won't update to new version
Close #2583
1 parent e670135 commit ba2957e

File tree

2 files changed

+25
-11
lines changed

2 files changed

+25
-11
lines changed

packages/electron-builder-lib/src/targets/differentialUpdateInfoBuilder.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,13 @@ export function createNsisWebDifferentialUpdateInfo(artifactPath: string, packag
2020
const packages: { [arch: string]: PackageFileInfo } = {}
2121
for (const arch of keys) {
2222
const packageFileInfo = packageFiles[arch]
23+
const file = path.basename(packageFileInfo.path)
2324
packages[arch] = {
2425
...packageFileInfo,
25-
path: path.basename(packageFileInfo.path)
26-
}
26+
path: file,
27+
// https://github.com/electron-userland/electron-builder/issues/2583
28+
file,
29+
} as any
2730
}
2831
return {packages}
2932
}

yarn.lock

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -485,8 +485,8 @@ atob@^2.0.0:
485485
resolved "https://registry.yarnpkg.com/atob/-/atob-2.0.3.tgz#19c7a760473774468f20b2d2d03372ad7d4cbf5d"
486486

487487
aws-sdk@^2.197.0:
488-
version "2.197.0"
489-
resolved "https://registry.yarnpkg.com/aws-sdk/-/aws-sdk-2.197.0.tgz#986e3749f4d1944c6253d7824aa8035efb1db0e4"
488+
version "2.198.0"
489+
resolved "https://registry.yarnpkg.com/aws-sdk/-/aws-sdk-2.198.0.tgz#2245311337ddc844cc34c13f3fcf3b7ea843f434"
490490
dependencies:
491491
buffer "4.9.1"
492492
events "^1.1.1"
@@ -2638,8 +2638,8 @@ ini@^1.3.4, ini@^1.3.5, ini@~1.3.0:
26382638
resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.5.tgz#eee25f56db1c9ec6085e0c22778083f596abf927"
26392639

26402640
invariant@^2.2.2:
2641-
version "2.2.2"
2642-
resolved "https://registry.yarnpkg.com/invariant/-/invariant-2.2.2.tgz#9e1f56ac0acdb6bf303306f338be3b204ae60360"
2641+
version "2.2.3"
2642+
resolved "https://registry.yarnpkg.com/invariant/-/invariant-2.2.3.tgz#1a827dfde7dcbd7c323f0ca826be8fa7c5e9d688"
26432643
dependencies:
26442644
loose-envify "^1.0.0"
26452645

@@ -3655,8 +3655,8 @@ lunr@0.5.12:
36553655
resolved "https://registry.yarnpkg.com/lunr/-/lunr-0.5.12.tgz#a2f6b7d7801cbe2ccb1696da67f1f7788f89e0c8"
36563656

36573657
make-dir@^1.0.0:
3658-
version "1.1.0"
3659-
resolved "https://registry.yarnpkg.com/make-dir/-/make-dir-1.1.0.tgz#19b4369fe48c116f53c2af95ad102c0e39e85d51"
3658+
version "1.2.0"
3659+
resolved "https://registry.yarnpkg.com/make-dir/-/make-dir-1.2.0.tgz#6d6a49eead4aae296c53bbf3a1a008bd6c89469b"
36603660
dependencies:
36613661
pify "^3.0.0"
36623662

@@ -4583,10 +4583,11 @@ regex-cache@^0.4.2:
45834583
is-equal-shallow "^0.1.3"
45844584

45854585
regex-not@^1.0.0:
4586-
version "1.0.0"
4587-
resolved "https://registry.yarnpkg.com/regex-not/-/regex-not-1.0.0.tgz#42f83e39771622df826b02af176525d6a5f157f9"
4586+
version "1.0.2"
4587+
resolved "https://registry.yarnpkg.com/regex-not/-/regex-not-1.0.2.tgz#1f4ece27e00b0b65e0247a6810e6a85d83a5752c"
45884588
dependencies:
4589-
extend-shallow "^2.0.1"
4589+
extend-shallow "^3.0.2"
4590+
safe-regex "^1.1.0"
45904591

45914592
registry-auth-token@^3.0.1:
45924593
version "3.3.2"
@@ -4729,6 +4730,10 @@ resolve@^1.0.0, resolve@^1.3.2:
47294730
dependencies:
47304731
path-parse "^1.0.5"
47314732

4733+
ret@~0.1.10:
4734+
version "0.1.15"
4735+
resolved "https://registry.yarnpkg.com/ret/-/ret-0.1.15.tgz#b8a4825d5bdb1fc3f6f53c2bc33f81388681c7bc"
4736+
47324737
right-align@^0.1.1:
47334738
version "0.1.3"
47344739
resolved "https://registry.yarnpkg.com/right-align/-/right-align-0.1.3.tgz#61339b722fe6a3515689210d24e14c96148613ef"
@@ -4745,6 +4750,12 @@ safe-buffer@^5.0.1, safe-buffer@^5.1.1, safe-buffer@~5.1.0, safe-buffer@~5.1.1:
47454750
version "5.1.1"
47464751
resolved "https://registry.yarnpkg.com/safe-buffer/-/safe-buffer-5.1.1.tgz#893312af69b2123def71f57889001671eeb2c853"
47474752

4753+
safe-regex@^1.1.0:
4754+
version "1.1.0"
4755+
resolved "https://registry.yarnpkg.com/safe-regex/-/safe-regex-1.1.0.tgz#40a3669f3b077d1e943d44629e157dd48023bf2e"
4756+
dependencies:
4757+
ret "~0.1.10"
4758+
47484759
sane@^2.0.0:
47494760
version "2.4.1"
47504761
resolved "https://registry.yarnpkg.com/sane/-/sane-2.4.1.tgz#29f991208cf28636720efdc584293e7fd66663a5"

0 commit comments

Comments
 (0)