Skip to content

fix: change find execution level logic to handle multiple form atting styles #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

fix: change find execution level logic to handle multiple form atting styles #88

merged 1 commit into from
Jul 18, 2019

Conversation

dmascord
Copy link
Contributor

@dmascord dmascord commented Jul 17, 2019 •
edited by zcbenz
Loading

Fix #86.

The old logic couldn't cope with the element over multiple lines, so modified the logic to parse the level using " or '

@zcbenz zcbenz changed the title Issue #86 - change find execution level logic to handle multiple form… fix: change find execution level logic to handle multiple form atting styles Jul 18, 2019
zcbenz
zcbenz approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zcbenz zcbenz merged commit b807b34 into electron:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iexpress-created exe not modified correctly
2 participants
@dmascord @zcbenz