Skip to content

Added RCDATA replacing by "--set-rcdata" key #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

Added RCDATA replacing by "--set-rcdata" key #77

merged 1 commit into from
Jul 1, 2019

Conversation

AniSkyWorker
Copy link
Contributor

@AniSkyWorker AniSkyWorker commented Jul 6, 2018 •
edited
Loading

We need this feature to replace images and XML files embedded into our *.exe installers (online installers).

--set-rcdata option expects filepath - this path will be read as binary and embed as RCDATA resource with given ID
RCDATA resource with such ID must exist before rcedit will try to replace it.

@zcbenz zcbenz merged commit 3a8e823 into electron:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AniSkyWorker @zcbenz