Skip to content

Reverting per monitor dpi aware causing issues with different dpis #9708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

juturu
Copy link
Contributor

@juturu juturu commented Jun 9, 2017

Fixes #9688 #9560 #9691

Reverts #8786

@juturu juturu requested review from zcbenz and kevinsawicki June 9, 2017 04:05
@kevinsawicki kevinsawicki requested review from alespergl and miniak June 9, 2017 15:09
@alespergl
Copy link
Contributor

I don't think this is a good way to go about solving the mentioned issues and view it as a step backwards. I would much rather see an actual fix to the mentioned problems instead of reverting per-monitor DPI awareness. IMO the user experience without per-monitor DPI awareness is worse than a window placement bug.

@juturu
Copy link
Contributor Author

juturu commented Jun 9, 2017

This is a blocking issue and want to resolve quickly for folks to move forward. I think there are other issues with the actual fix of per-monitor dpi aware and needs more investigation. If we don't want to revert and continue investigation on higher priority, i'm good with it. If we can't get a fix out by next release, we should consider reverting the change to unblock people to move to latest electron. @kevinsawicki your thoughts?

@alespergl
Copy link
Contributor

alespergl commented Jun 9, 2017

This is a blocking issue and want to resolve quickly for folks to move forward.

I dare to doubt the gravity of the bug as something that would "block" a way "forward" for people. Can you be more specific? Note that per-monitor DPI awareness has been turned on for a couple of releases now.

@alexdevero
Copy link

Is there any update or progress on this issue?

@alespergl
Copy link
Contributor

I think we should close it. This does not provide a fix to the aforementioned issues.

@alexdevero
Copy link

@alespergl So, what are other solutions? I would love to see this fixed as I'm currently experiencing this scaling issue (Win 10, 125%).

@groundwater
Copy link
Contributor

This was put up for review in one of our standups. We would normally discuss this in out monday meeting, but most of us are in Tokyo next week, so perhaps an in-person conversation can be had there, if not we can make a final decision at the next standup.

@bpasero
Copy link
Contributor

bpasero commented Oct 18, 2017

VS Code is badly broken on Windows due to all the window position issues. Would like to see this merged eventually 👍

@alespergl
Copy link
Contributor

@bpasero This PR is not a fix for your problems, it's a workaround. VS Code can have this workaround applied internally - pm me if you need help with that.
We need to close this PR and replace it with a real fix without regressing high DPI funcionality.

@bpasero
Copy link
Contributor

bpasero commented Oct 19, 2017

@alespergl yes, thanks for clarifying. I would prefer the real fix too if possible :-).

@zcbenz
Copy link
Contributor

zcbenz commented Nov 14, 2017

This pull request has been hanging for too long, and apparently we don't have an agreement here. I'm closing this pull request and let's continue the discussion at #10862.

@zcbenz zcbenz closed this Nov 14, 2017
@zcbenz zcbenz deleted the dpi-bounds branch November 14, 2017 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants