fix: net.isOnline always true in utility processes
#48111
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
net.isOnline always true in utility orocesses
net.isOnline always true in utility orocessesnet.isOnline always true in utility processes
45c52a4 to
6a57fc5
Compare
deepak1556
reviewed
Aug 19, 2025
dsanders11
approved these changes
Aug 20, 2025
Co-authored-by: Robo <hop2deep@gmail.com>
4162760 to
ce3fa89
Compare
|
Release Notes Persisted
|
This was referenced Aug 22, 2025
|
I have automatically backported this PR to "38-x-y", please check out #48151 |
|
I have automatically backported this PR to "37-x-y", please check out #48152 |
|
I have automatically backported this PR to "36-x-y", please check out #48153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #48100.
Fixes an issue where
net.isOnline()always returnedtruein utilityProcesses. This happened because utility processes never created anet::NetworkChangeNotifier, sonet.isOnline()always saw a null global and defaulted to “online”.Fix this by adding a per‑utility‑process
NetworkChangeNotifierduringNodeService::Initialize()], allowingnet.isOnline()to reflect real connectivity.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
net.isOnline()always returnedtruein utilityProcesses.