fix: system accent color parsing hex order #48085
Merged
+12
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #48086
Closes https://github.com/electron/electron/issues
Refs #47741.
Fixes an issue where the accent color would be accidentally inverted when set to match the system color. This could be seen if you chose e.g. an orange, whose color opposite is blue; the window would have a blue border in that case. This happened because
DwmGetColorizationColor
returns a color formatted0xAARRGGBB
, and the parsing performed here usedGet{R|G|B}Value
to parse the color into aCOLORREF
. From documentation:Switch to pulling the color from the windows registry, which does not require extra conversion to ensure the color is in the right format.
cc @bpasero
Tested to ensure the color updates correctly with settings change.
Checklist
npm test
passesRelease Notes
Notes: Fixes an issue where the accent color would be accidentally inverted when set to match the system color.