Skip to content

fix: shell.openPath should be non-blocking #48079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

fix: shell.openPath should be non-blocking #48079

merged 1 commit into from
Aug 15, 2025

Conversation

codebytere
Copy link
Member

Description of Change

Closes #47668.

Fixes an issue where shell.openPath was not non-blocking as expected.

Checklist

Release Notes

Notes: Fixed an issue where shell.openPath was not non-blocking as expected.

@codebytere codebytere added target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Aug 14, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 14, 2025
@Hectate Hectate mentioned this pull request Aug 14, 2025
Open
@VerteDinde VerteDinde added the semver/patch backwards-compatible bug fixes label Aug 15, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 15, 2025
@VerteDinde VerteDinde merged commit 0e6c260 into main Aug 15, 2025
66 of 68 checks passed
@VerteDinde VerteDinde deleted the openpath-non-blocking branch August 15, 2025 20:55
@release-clerk
Copy link

release-clerk bot commented Aug 15, 2025

Release Notes Persisted

Fixed an issue where shell.openPath was not non-blocking as expected.

This was referenced Aug 15, 2025
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 15, 2025

I have automatically backported this PR to "36-x-y", please check out #48087

@trop
Copy link
Contributor

trop bot commented Aug 15, 2025

I have automatically backported this PR to "37-x-y", please check out #48088

@trop trop bot removed the target/36-x-y PR should also be added to the "36-x-y" branch. label Aug 15, 2025
@trop
Copy link
Contributor

trop bot commented Aug 15, 2025

I have automatically backported this PR to "38-x-y", please check out #48089

@trop trop bot added in-flight/37-x-y in-flight/38-x-y merged/36-x-y PR was merged to the "36-x-y" branch. and removed target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/36-x-y in-flight/38-x-y labels Aug 15, 2025
@trop trop bot added merged/38-x-y PR was merged to the "38-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. and removed in-flight/37-x-y labels Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shell.openPath is blocking on Linux when it should be non-blocking
3 participants
@codebytere @deepak1556 @VerteDinde