Skip to content

fix: webContent.fromId should be number instead of string #48059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025

Conversation

reitowo
Copy link
Member

@reitowo reitowo commented Aug 12, 2025

Description of Change

The fromId defined in the file accepts a string arg, while the api docs are number, the native binding also wants a int32.

Release Notes

Notes: none

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@jkleinsc jkleinsc merged commit ceb6d28 into electron:main Aug 22, 2025
64 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 22, 2025

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants