Skip to content

fix: app.accessibilitySupportEnabled #48041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

fix: app.accessibilitySupportEnabled #48041

merged 1 commit into from
Aug 12, 2025

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 11, 2025 •
edited
Loading

Description of Change

Closes #48039.

Fixes an issue where app.accessibilitySupportEnabled didn't work as expected. This happened as a result of #46118.

Checklist

Release Notes

Notes: Fixed an issue where app.accessibilitySupportEnabled didn't work as expected.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Aug 11, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 11, 2025
deepak1556
deepak1556 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danielweck
Copy link

Thank you team! :)

@danielweck danielweck mentioned this pull request Aug 11, 2025
Closed
@danielweck
Copy link

Note that this probably doesn't only affect MacOS / VoiceOver. NVDA / JAWS users have reported bugs that indicate that screen reader detection is broken in Windows too.

@codebytere codebytere changed the title fix: app.accessibilitySupportEnabled on macOS fix: app.accessibilitySupportEnabled Aug 11, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 12, 2025
@jkleinsc jkleinsc merged commit 53003d7 into main Aug 12, 2025
104 of 105 checks passed
@jkleinsc jkleinsc deleted the fix-ax-mode branch August 12, 2025 20:51
@release-clerk
Copy link

release-clerk bot commented Aug 12, 2025

Release Notes Persisted

Fixed an issue where app.accessibilitySupportEnabled didn't work as expected.

This was referenced Aug 12, 2025
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 12, 2025

I have automatically backported this PR to "38-x-y", please check out #48060

@trop trop bot added in-flight/38-x-y and removed target/38-x-y PR should also be added to the "38-x-y" branch. labels Aug 12, 2025
@trop
Copy link
Contributor

trop bot commented Aug 12, 2025

I have automatically backported this PR to "37-x-y", please check out #48061

@trop trop bot added in-flight/37-x-y merged/37-x-y PR was merged to the "37-x-y" branch. and removed target/37-x-y PR should also be added to the "37-x-y" branch. in-flight/37-x-y labels Aug 12, 2025
@trop trop bot added merged/38-x-y PR was merged to the "38-x-y" branch. and removed in-flight/38-x-y labels Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

accessibilitySupportEnabled (screen reader detection) is broken since v37 (worked in v36)
4 participants
@codebytere @danielweck @jkleinsc @deepak1556