Skip to content

feat: add ColorSpace #47314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2025
Merged

feat: add ColorSpace #47314

merged 3 commits into from
Jul 2, 2025

Conversation

reitowo
Copy link
Member

@reitowo reitowo commented May 30, 2025 •
edited
Loading

Description of Change

Add ColorSpace structure, split from #46811

This structure will be added to paint event's textureInfo when using shared texture OSR, and will be used in import shared texture. We have to keep full color space info. This also get ready for HDR capturing support in the future.

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 30, 2025
@reitowo reitowo mentioned this pull request May 30, 2025
Closed
@reitowo reitowo force-pushed the main-color-space branch 2 times, most recently from 37ea2f6 to 0b61073 Compare May 31, 2025 07:17
@deepak1556 deepak1556 added the semver/minor backwards-compatible functionality label Jun 4, 2025
@reitowo reitowo force-pushed the main-color-space branch from 0b61073 to f003085 Compare June 4, 2025 15:35
samuelmaddock
samuelmaddock reviewed Jun 5, 2025
View reviewed changes
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 6, 2025
@reitowo reitowo force-pushed the main-color-space branch from 7df7525 to 988ab97 Compare June 11, 2025 02:40
@reitowo
Copy link
Member Author

reitowo commented Jun 11, 2025

Rebased to latest main, maybe CI is now runable?

jkleinsc
jkleinsc approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

erickzhao
erickzhao approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

dcq01

This comment was marked as spam.

Sign in to view

@erickzhao
Copy link
Member

erickzhao commented Jun 25, 2025 •
edited
Loading

Hey @dcq01, I think the LLM-generated review comments feel disruptive to the review process. Please refrain from leaving these again in the future.

@reitowo reitowo force-pushed the main-color-space branch from 62c5b3e to dc28e64 Compare June 26, 2025 17:21
@reitowo
Copy link
Member Author

reitowo commented Jun 30, 2025 •
edited
Loading

Anyone could trigger the CI again? 😂

@MarshallOfSound MarshallOfSound merged commit fb0b77b into electron:main Jul 2, 2025
51 of 53 checks passed
@release-clerk
Copy link

release-clerk bot commented Jul 2, 2025

No Release Notes

codebytere pushed a commit that referenced this pull request Jul 11, 2025
@reitowo @codebytere
feat: add ColorSpace (#47314)
bf7d8cb
@samuelmaddock samuelmaddock mentioned this pull request Jul 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmaddock samuelmaddock samuelmaddock left review comments

@jkleinsc jkleinsc jkleinsc approved these changes

+2 more reviewers

@dcq01 dcq01 dcq01 left review comments

@erickzhao erickzhao erickzhao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api-review/approved ✅ no-backport semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@reitowo @erickzhao @jkleinsc @samuelmaddock @dcq01 @deepak1556 @MarshallOfSound