Skip to content

fix: titlebar showing in content protected window #47241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

fix: titlebar showing in content protected window #47241

merged 1 commit into from
May 26, 2025
+27 −2

Conversation

codebytere
Copy link
Member

Description of Change

Closes #47152.

Fixes an issue where protected transparent windows will show a titlebar after visibility change. This happened because SetWindowDisplayAffinity will attempt to compose the window when hidden and re-shown.

Checklist

Release Notes

Notes: Fixed an issue where protected transparent windows inappropriately showed a titlebar after visibility change.

@codebytere codebytere requested review from ckerr and deepak1556 May 23, 2025 07:48
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels May 23, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 23, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 24, 2025
@codebytere codebytere merged commit f89c2a0 into main May 26, 2025
67 checks passed
@codebytere codebytere deleted the fix-titlebar-content-protection branch May 26, 2025 07:46
@release-clerk
Copy link

release-clerk bot commented May 26, 2025

Release Notes Persisted

Fixed an issue where protected transparent windows inappropriately showed a titlebar after visibility change.

This was referenced May 26, 2025
Merged
Merged
@trop
Copy link
Contributor

trop bot commented May 26, 2025

I have automatically backported this PR to "36-x-y", please check out #47264

@trop
Copy link
Contributor

trop bot commented May 26, 2025

I have automatically backported this PR to "35-x-y", please check out #47265

@trop trop bot added in-flight/36-x-y in-flight/35-x-y and removed target/36-x-y PR should also be added to the "36-x-y" branch. target/35-x-y PR should also be added to the "35-x-y" branch. labels May 26, 2025
@trop trop bot mentioned this pull request May 26, 2025
Merged
@trop
Copy link
Contributor

trop bot commented May 26, 2025

I have automatically backported this PR to "37-x-y", please check out #47266

@trop trop bot added in-flight/37-x-y merged/36-x-y PR was merged to the "36-x-y" branch. merged/35-x-y PR was merged to the "35-x-y" branch. and removed target/37-x-y PR should also be added to the "37-x-y" branch. in-flight/36-x-y in-flight/35-x-y labels May 26, 2025
@trop trop bot added merged/37-x-y PR was merged to the "37-x-y" branch. and removed in-flight/37-x-y labels May 27, 2025
@oalfroukh oalfroukh mentioned this pull request Jul 20, 2025
Open
3 tasks
@nikwen
Copy link
Member

nikwen commented Jul 21, 2025

This PR led to a regression: #47241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create a frame for the transparent protected browser window once minimize another window
4 participants
@codebytere @nikwen @ckerr @deepak1556