Skip to content

fix: compilation error when disabling extensions and pdf_viewer #47964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

fix: compilation error when disabling extensions and pdf_viewer #47964

merged 1 commit into from
Aug 7, 2025

Conversation

wujinli
Copy link
Contributor

@wujinli wujinli commented Aug 5, 2025 •
edited
Loading

Description of Change

here we fix the compile error:

// args.gn file
enable_electron_extensions=false
enable_pdf_viewer=false

Checklist

Release Notes

Notes: Fixed compilation error when disabling extensions and pdf_viewer

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 5, 2025
@wujinli wujinli force-pushed the fix_compile_error branch from 5309f70 to a3480a2 Compare August 5, 2025 11:16
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Aug 5, 2025
@wujinli wujinli changed the title Fixed compilation error when disabling extensions and pdf_viewer fix: compilation error when disabling extensions and pdf_viewer Aug 5, 2025
@wujinli wujinli force-pushed the fix_compile_error branch from a3480a2 to 9de4788 Compare August 5, 2025 12:34
@wujinli
Copy link
Contributor Author

wujinli commented Aug 5, 2025

@codebytere Hi, Please help to trigger tests again. Changes: Syntax formatting

@wujinli
Copy link
Contributor Author

wujinli commented Aug 6, 2025

The test failure is due to infrastructure issues. Please help fix this.
In fact, most architectures have already passed the tests, except for the linux-arm64 mocha tests, which proves that there are no issues with this commit. Therefore, you can skip the tests and merge directly.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 6, 2025
@wujinli
Copy link
Contributor Author

wujinli commented Aug 6, 2025

@codebytere @dsanders11 Can someone help me sort it out?

jkleinsc
jkleinsc requested changes Aug 7, 2025
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just needs a small change on the comment

@wujinli wujinli force-pushed the fix_compile_error branch from 9de4788 to 54971e9 Compare August 7, 2025 02:18
@wujinli
Copy link
Contributor Author

wujinli commented Aug 7, 2025

Looks good to me, just needs a small change on the comment

@jkleinsc Done. At the same time, another original error in the same file is also corrected.

@wujinli wujinli requested a review from jkleinsc August 7, 2025 02:19
@wujinli
Copy link
Contributor Author

wujinli commented Aug 7, 2025

The test failure is not related to this commit.

@jkleinsc jkleinsc merged commit f49a645 into electron:main Aug 7, 2025
101 of 103 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 7, 2025

Release Notes Persisted

Fixed compilation error when disabling extensions and pdf_viewer

This was referenced Aug 7, 2025
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 7, 2025

I have automatically backported this PR to "38-x-y", please check out #47993

@trop trop bot added the in-flight/38-x-y label Aug 7, 2025
@trop
Copy link
Contributor

trop bot commented Aug 7, 2025

I have automatically backported this PR to "37-x-y", please check out #47994

@trop trop bot added in-flight/37-x-y and removed target/38-x-y PR should also be added to the "38-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels Aug 7, 2025
@trop trop bot added merged/38-x-y PR was merged to the "38-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. and removed in-flight/38-x-y in-flight/37-x-y labels Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wujinli @jkleinsc @codebytere @dsanders11