-
Notifications
You must be signed in to change notification settings - Fork 16.3k
chore: bump chromium to 140.0.7327.0 (main) #47902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3a7fe73
to
9ec252c
Compare
dict.Set("colorSpace", val.GetColorSpaces() | ||
.GetRasterAndCompositeColorSpace( | ||
gfx::ContentColorUsage::kWideColorGamut) | ||
.ToString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These params were taken from this snippet in the CL which also converts to a string.
Note that it changes the output:
[
{
accelerometerSupport: 'unknown',
bounds: { x: 0, y: 0, width: 1920, height: 1080 },
colorDepth: 30,
- colorSpace: '{primaries:BT709, transfer:SRGB_HDR, matrix:RGB, range:FULL}',
+ colorSpace: '{primaries:P3, transfer:SRGB, matrix:RGB, range:FULL}',
depthPerComponent: 10,
detected: true,
displayFrequency: 60.000003814697266,
id: 4,
internal: false,
label: 'DELL U2720Q',
maximumCursorSize: { width: 0, height: 0 },
monochrome: false,
nativeOrigin: { x: 0, y: 0 },
rotation: 0,
scaleFactor: 2,
size: { width: 1920, height: 1080 },
workArea: { x: 0, y: 25, width: 1920, height: 1055 },
workAreaSize: { width: 1920, height: 1055 },
touchSupport: 'unknown'
},
{
accelerometerSupport: 'unknown',
bounds: { x: -1728, y: 377, width: 1728, height: 1117 },
colorDepth: 30,
- colorSpace: '{primaries:BT709, transfer:SRGB_HDR, matrix:RGB, range:FULL}',
+ colorSpace: '{primaries:P3, transfer:{0.0777*x + 0.0000 if abs(x) < 0.0450 else sign(x)*((0.9495*abs(x) + 0.0495)**2.3955 + 0.0003)}, matrix:RGB, range:FULL}',
depthPerComponent: 10,
detected: true,
displayFrequency: 120.00000762939453,
id: 1,
internal: true,
label: 'Built-in Retina Display',
maximumCursorSize: { width: 0, height: 0 },
monochrome: false,
nativeOrigin: { x: 0, y: 0 },
rotation: 0,
scaleFactor: 2,
size: { width: 1728, height: 1117 },
workArea: { x: -1728, y: 415, width: 1728, height: 1079 },
workAreaSize: { width: 1728, height: 1079 },
touchSupport: 'unknown'
}
]
If we want to restore the same values as before, we can use the following, but forcing the HDR color space doesn't seem quite right.
dict.Set("colorSpace", val.GetColorSpaces() | |
.GetRasterAndCompositeColorSpace( | |
gfx::ContentColorUsage::kWideColorGamut) | |
.ToString()); | |
dict.Set("colorSpace", | |
val.GetColorSpaces() | |
.GetOutputColorSpace(gfx::ContentColorUsage::kHDR, false) | |
.ToString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an aside, we should consider moving to the ColorSpace
struct in the future #47314
|
||
+// TODO(smaddock): Migrate to SecItem* as part of | ||
+// https://issues.chromium.org/issues/40233280 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://chromium-review.googlesource.com/c/chromium/src/+/6736212 moved the keychain code into the /crypto/apple
dir. When updating the patch, it required making changes to all subclasses of Keychain
to define the ItemDelete
method.
AppleSecKeychainItemRef
is only set for the deprecated SecKeychain*
APIs so it doesn't make sense to use for the newer SecItem*
APIs. Once SecKeychain*
code is removed, we we'll need to implement ItemDelete
for SecItem*
usage.
Merging as the MAS test failures are related to #47877 I believe the tests hang due to a Bluetooth permission popup. I was able to repro locally when it appears. |
Release Notes Persisted
|
I have automatically backported this PR to "38-x-y", please check out #47930 |
Updating Chromium to 140.0.7327.0.
See all changes in 140.0.7314.0..140.0.7327.0
Notes: Updated Chromium to 140.0.7327.0.