Skip to content

chore: bump chromium to 140.0.7327.0 (main) #47902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 31, 2025
Merged

Conversation

electron-roller[bot]
Copy link
Contributor

@electron-roller electron-roller bot commented Jul 28, 2025

Updating Chromium to 140.0.7327.0.

See all changes in 140.0.7314.0..140.0.7327.0

Notes: Updated Chromium to 140.0.7327.0.

@electron-roller electron-roller bot added no-backport semver/patch backwards-compatible bug fixes labels Jul 28, 2025
@electron-roller electron-roller bot requested a review from a team as a code owner July 28, 2025 22:32
@electron-roller electron-roller bot added semver/patch backwards-compatible bug fixes no-backport labels Jul 28, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 28, 2025
@electron-roller electron-roller bot changed the title chore: bump chromium to 140.0.7324.0 (main) chore: bump chromium to 140.0.7325.0 (main) Jul 29, 2025
@jkleinsc jkleinsc added target/38-x-y PR should also be added to the "38-x-y" branch. and removed no-backport labels Jul 29, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 29, 2025
@samuelmaddock samuelmaddock requested a review from a team as a code owner July 30, 2025 01:43
@electron-roller electron-roller bot changed the title chore: bump chromium to 140.0.7325.0 (main) chore: bump chromium to 140.0.7327.0 (main) Jul 30, 2025
electron-roller bot and others added 16 commits July 31, 2025 09:51
@samuelmaddock samuelmaddock force-pushed the roller/chromium/main branch 2 times, most recently from 3a7fe73 to 9ec252c Compare July 31, 2025 13:52
Comment on lines +180 to +183
dict.Set("colorSpace", val.GetColorSpaces()
.GetRasterAndCompositeColorSpace(
gfx::ContentColorUsage::kWideColorGamut)
.ToString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These params were taken from this snippet in the CL which also converts to a string.
Screenshot 2025-07-31 at 12 51 32 PM

Note that it changes the output:

[
  {
    accelerometerSupport: 'unknown',
    bounds: { x: 0, y: 0, width: 1920, height: 1080 },
    colorDepth: 30,
-    colorSpace: '{primaries:BT709, transfer:SRGB_HDR, matrix:RGB, range:FULL}',
+    colorSpace: '{primaries:P3, transfer:SRGB, matrix:RGB, range:FULL}',
    depthPerComponent: 10,
    detected: true,
    displayFrequency: 60.000003814697266,
    id: 4,
    internal: false,
    label: 'DELL U2720Q',
    maximumCursorSize: { width: 0, height: 0 },
    monochrome: false,
    nativeOrigin: { x: 0, y: 0 },
    rotation: 0,
    scaleFactor: 2,
    size: { width: 1920, height: 1080 },
    workArea: { x: 0, y: 25, width: 1920, height: 1055 },
    workAreaSize: { width: 1920, height: 1055 },
    touchSupport: 'unknown'
  },
  {
    accelerometerSupport: 'unknown',
    bounds: { x: -1728, y: 377, width: 1728, height: 1117 },
    colorDepth: 30,
-    colorSpace: '{primaries:BT709, transfer:SRGB_HDR, matrix:RGB, range:FULL}',
+    colorSpace: '{primaries:P3, transfer:{0.0777*x + 0.0000 if abs(x) < 0.0450 else sign(x)*((0.9495*abs(x) + 0.0495)**2.3955 + 0.0003)}, matrix:RGB, range:FULL}',
    depthPerComponent: 10,
    detected: true,
    displayFrequency: 120.00000762939453,
    id: 1,
    internal: true,
    label: 'Built-in Retina Display',
    maximumCursorSize: { width: 0, height: 0 },
    monochrome: false,
    nativeOrigin: { x: 0, y: 0 },
    rotation: 0,
    scaleFactor: 2,
    size: { width: 1728, height: 1117 },
    workArea: { x: -1728, y: 415, width: 1728, height: 1079 },
    workAreaSize: { width: 1728, height: 1079 },
    touchSupport: 'unknown'
  }
]

If we want to restore the same values as before, we can use the following, but forcing the HDR color space doesn't seem quite right.

Suggested change
dict.Set("colorSpace", val.GetColorSpaces()
.GetRasterAndCompositeColorSpace(
gfx::ContentColorUsage::kWideColorGamut)
.ToString());
dict.Set("colorSpace",
val.GetColorSpaces()
.GetOutputColorSpace(gfx::ContentColorUsage::kHDR, false)
.ToString());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, we should consider moving to the ColorSpace struct in the future #47314


+// TODO(smaddock): Migrate to SecItem* as part of
+// https://issues.chromium.org/issues/40233280
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://chromium-review.googlesource.com/c/chromium/src/+/6736212 moved the keychain code into the /crypto/apple dir. When updating the patch, it required making changes to all subclasses of Keychain to define the ItemDelete method.

AppleSecKeychainItemRef is only set for the deprecated SecKeychain* APIs so it doesn't make sense to use for the newer SecItem* APIs. Once SecKeychain* code is removed, we we'll need to implement ItemDelete for SecItem* usage.

@samuelmaddock
Copy link
Member

Merging as the MAS test failures are related to #47877

I believe the tests hang due to a Bluetooth permission popup. I was able to repro locally when it appears.

@samuelmaddock samuelmaddock merged commit 03aad28 into main Jul 31, 2025
98 of 102 checks passed
@samuelmaddock samuelmaddock deleted the roller/chromium/main branch July 31, 2025 22:11
@release-clerk
Copy link

release-clerk bot commented Jul 31, 2025

Release Notes Persisted

Updated Chromium to 140.0.7327.0.

@trop
Copy link
Contributor

trop bot commented Jul 31, 2025

I have automatically backported this PR to "38-x-y", please check out #47930

@trop trop bot added in-flight/38-x-y merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/38-x-y labels Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/38-x-y PR was merged to the "38-x-y" branch. roller/pause semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants