Skip to content

ci: fixup mac runners #47877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

ci: fixup mac runners #47877

merged 1 commit into from
Jul 28, 2025

Conversation

jkleinsc
Copy link
Member

@jkleinsc jkleinsc commented Jul 23, 2025 •
edited
Loading

Description of Change

  • This fixes the hang on device tests on macOS arm64 that was disabled in test: cleanup RenderFrame lifespan tests #47746.
  • Additionally, this PR disables macOS's spotlight indexing which will free up some disk space and may help improve build performance.

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 23, 2025
@jkleinsc jkleinsc force-pushed the fixup-mac-runners branch from 4f4ff5d to 8559276 Compare July 23, 2025 21:23
@jkleinsc jkleinsc force-pushed the fixup-mac-runners branch from 8559276 to f758223 Compare July 24, 2025 15:26
@jkleinsc jkleinsc changed the title Fixup mac runners ci: fixup mac runners Jul 24, 2025
@electron-cation electron-cation bot added semver/none and removed new-pr 🌱 PR opened recently labels Jul 24, 2025
@jkleinsc jkleinsc marked this pull request as ready for review July 24, 2025 15:29
@jkleinsc jkleinsc requested a review from a team as a code owner July 24, 2025 15:29
@jkleinsc jkleinsc added target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 25, 2025
@jkleinsc jkleinsc merged commit 06d7a51 into main Jul 28, 2025
114 of 117 checks passed
@jkleinsc jkleinsc deleted the fixup-mac-runners branch July 28, 2025 17:37
@release-clerk
Copy link

release-clerk bot commented Jul 28, 2025

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jul 28, 2025

I was unable to backport this PR to "35-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/35-x-y PR should also be added to the "35-x-y" branch. label Jul 28, 2025
@trop trop bot mentioned this pull request Jul 28, 2025
Closed
This was referenced Jul 28, 2025
Merged
Closed
@trop
Copy link
Contributor

trop bot commented Jul 28, 2025

I have automatically backported this PR to "38-x-y", please check out #47898

@trop
Copy link
Contributor

trop bot commented Jul 28, 2025

I have automatically backported this PR to "36-x-y", please check out #47899

@trop
Copy link
Contributor

trop bot commented Jul 28, 2025

I have automatically backported this PR to "37-x-y", please check out #47900

@trop trop bot added in-flight/36-x-y in-flight/37-x-y and removed target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 28, 2025
@trop trop bot added merged/36-x-y PR was merged to the "36-x-y" branch. and removed target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. in-flight/36-x-y labels Jul 28, 2025
@jkleinsc jkleinsc mentioned this pull request Jul 30, 2025
Merged
4 tasks
@samuelmaddock samuelmaddock mentioned this pull request Jul 31, 2025
Merged
@jkleinsc jkleinsc mentioned this pull request Aug 7, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
merged/36-x-y PR was merged to the "36-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @MarshallOfSound