Skip to content

fix: dark mode on Linux default themeing #47869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

fix: dark mode on Linux default themeing #47869

merged 1 commit into from
Jul 31, 2025

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jul 23, 2025 •
edited
Loading

Description of Change

Closes #47842
Refs CL:6469606

Fixes an issue where windows used dark theme on Linux all the time without reacting to system theme changes.

We need to take an approach similar to that in BrowserDesktopWindowTreeHostLinux and override the prefers_dark_theme property based on our own ui::LinuxUiGetter.

Checklist

Release Notes

Notes: Fixed an issue where windows used dark theme on Linux all the time without reacting to system theme changes.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 23, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 23, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 24, 2025
@codebytere codebytere force-pushed the fix-linux-dark-mode branch from 2c7a09c to ace2a1a Compare July 24, 2025 11:37
@codebytere codebytere merged commit 4c9ab87 into main Jul 31, 2025
56 checks passed
@codebytere codebytere deleted the fix-linux-dark-mode branch July 31, 2025 08:54
@release-clerk
Copy link

release-clerk bot commented Jul 31, 2025

Release Notes Persisted

Fixed an issue where windows used dark theme on Linux all the time without reacting to system theme changes.

This was referenced Jul 31, 2025
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 31, 2025

I have automatically backported this PR to "38-x-y", please check out #47919

@trop trop bot added in-flight/38-x-y and removed target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 31, 2025
@trop
Copy link
Contributor

trop bot commented Jul 31, 2025

I have automatically backported this PR to "37-x-y", please check out #47920

@trop trop bot added in-flight/37-x-y merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/37-x-y PR should also be added to the "37-x-y" branch. in-flight/37-x-y in-flight/38-x-y labels Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title bar color is always black on linux
2 participants
@codebytere @deepak1556