Skip to content

fix: default to system accent color on invalid user color #47800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

fix: default to system accent color on invalid user color #47800

merged 1 commit into from
Jul 31, 2025

Conversation

codebytere
Copy link
Member

Backport of #47660.

See that PR for details.

Notes: Fixes an issue where an invalid color passed as a string to accentColor would result in a white accent color.

@codebytere codebytere requested a review from a team July 17, 2025 08:03
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 17, 2025
@trop trop bot mentioned this pull request Jul 17, 2025
Merged
3 tasks
@codebytere codebytere marked this pull request as ready for review July 17, 2025 08:03
@trop trop bot added 37-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 17, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 17, 2025
@codebytere codebytere added new-pr 🌱 PR opened recently target/36-x-y PR should also be added to the "36-x-y" branch. labels Jul 17, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 17, 2025
@codebytere codebytere force-pushed the default-undefined-on-failed-37 branch from e471fcf to 6fb0b79 Compare July 21, 2025 10:18
clavin
clavin approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@clavin clavin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@codebytere codebytere merged commit e17cbc9 into 37-x-y Jul 31, 2025
53 of 55 checks passed
@codebytere codebytere deleted the default-undefined-on-failed-37 branch July 31, 2025 09:10
@release-clerk
Copy link

release-clerk bot commented Jul 31, 2025

Release Notes Persisted

Fixes an issue where an invalid color passed as a string to accentColor would result in a white accent color.

@trop
Copy link
Contributor

trop bot commented Jul 31, 2025

I have automatically backported this PR to "36-x-y", please check out #47921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clavin clavin clavin approved these changes

Assignees
No one assigned
Labels
37-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes target/36-x-y PR should also be added to the "36-x-y" branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @clavin