Skip to content

fix: window accentColor should adhere to native window behavior #47740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2025
Merged

fix: window accentColor should adhere to native window behavior #47740

merged 3 commits into from
Jul 17, 2025
+11 −7

Conversation

codebytere
Copy link
Member

Description of Change

Closes #47723.

Fixes an issue where the accent border was drawn on all windows regardless of the window's active focused status. As of this PR by default the accent border will be drawn on active frameless windows unless the user specified accentColor: true or a color in which case it will be drawn on all windows.

cc @bpasero

Checklist

Release Notes

Notes: Fixes an issue where the accent border was drawn on all windows regardless of the window's active focused status.

@codebytere codebytere requested a review from deepak1556 July 14, 2025 07:58
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 14, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 14, 2025
@codebytere codebytere requested review from clavin and mlaurencin July 14, 2025 07:58
@bpasero
Copy link
Contributor

bpasero commented Jul 14, 2025

👍 , @codebytere this probably deserves some updates to the docs around this option so that its really clear whats happening depending on the property use.

deepak1556
deepak1556 reviewed Jul 14, 2025
View reviewed changes
@codebytere codebytere force-pushed the accent-window-default-active branch from 1273396 to 3435aca Compare July 14, 2025 14:21
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 15, 2025
@codebytere codebytere force-pushed the accent-window-default-active branch from 3435aca to 31d8bc7 Compare July 16, 2025 10:04
@codebytere codebytere requested a review from deepak1556 July 16, 2025 10:28
@codebytere codebytere merged commit 31725b4 into main Jul 17, 2025
56 of 57 checks passed
@codebytere codebytere deleted the accent-window-default-active branch July 17, 2025 08:59
@release-clerk
Copy link

release-clerk bot commented Jul 17, 2025

Release Notes Persisted

Fixes an issue where the accent border was drawn on all windows regardless of the window's active focused status.

@trop
Copy link
Contributor

trop bot commented Jul 17, 2025

I was unable to backport this PR to "37-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/37-x-y PR should also be added to the "37-x-y" branch. label Jul 17, 2025
@trop
Copy link
Contributor

trop bot commented Jul 17, 2025

I was unable to backport this PR to "36-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/37-x-y needs-manual-bp/36-x-y and removed target/36-x-y PR should also be added to the "36-x-y" branch. labels Jul 17, 2025
@trop trop bot mentioned this pull request Jul 17, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Jul 17, 2025

I have automatically backported this PR to "38-x-y", please check out #47802

@trop trop bot added merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/38-x-y labels Jul 17, 2025
@codebytere
Copy link
Member Author

/trop run backport-to 37-x-y,36-x-y

@trop
Copy link
Contributor

trop bot commented Aug 8, 2025

The backport process for this PR has been manually initiated - sending your PR to 37-x-y!

@trop
Copy link
Contributor

trop bot commented Aug 8, 2025

The backport process for this PR has been manually initiated - sending your PR to 36-x-y!

This was referenced Aug 8, 2025
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 8, 2025

I have automatically backported this PR to "37-x-y", please check out #48011

@trop
Copy link
Contributor

trop bot commented Aug 8, 2025

I have automatically backported this PR to "36-x-y", please check out #48012

@trop trop bot added in-flight/36-x-y merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. and removed needs-manual-bp/36-x-y in-flight/36-x-y in-flight/37-x-y labels Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@clavin clavin Awaiting requested review from clavin

@mlaurencin mlaurencin Awaiting requested review from mlaurencin

Assignees
No one assigned
Labels
merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window accentColor should only apply to active window
3 participants
@codebytere @bpasero @deepak1556