Skip to content

fix: video scrubbing on playback #47703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2025
Merged

fix: video scrubbing on playback #47703

merged 2 commits into from
Aug 5, 2025

Conversation

VerteDinde
Copy link
Member

Description of Change

Fixes #47661

This PR slightly modifies an existing patch to MultibufferDataSource to correctly set the supported range on scrub.

Note: There is currently upstream work around MultiBufferNeverDefer v2 which changed this code (see this crbug: https://issues.chromium.org/issues/41161335); future upstream CLs may result in the patch needing to change again in the near future.

Checklist

Release Notes

Notes: Fixed an issue where video scrubbing would not correctly hold the new position on playback.

@VerteDinde VerteDinde requested a review from a team as a code owner July 9, 2025 20:46
@VerteDinde VerteDinde added semver/patch backwards-compatible bug fixes target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 9, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 9, 2025
@VerteDinde VerteDinde requested a review from codebytere July 9, 2025 20:46
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 10, 2025
@codebytere codebytere changed the title fix: fix video scrubbing on playback fix: video scrubbing on playback Jul 11, 2025
@agsimmons agsimmons mentioned this pull request Jul 21, 2025
Open
3 tasks
@danielweck
Copy link

hello, what's blocking the merge? Audio/video seeking is broken in Electron 37, 38, 39 (works in 36) when serving media resources via registerStreamProtocol / protocol.handle, we're currently considering a rollback to v36 but we would obviously prefer to release our app with a more current Electron / Chromium revision. Thank you :)

@danielweck
Copy link

The only failing check seems to be a timeout?
https://github.com/electron/electron/actions/runs/16179835505/job/45734312883?pr=47703

@codebytere
Copy link
Member

@danielweck there is feedback that needs to be incorporated. I'll try to update it today.

@danielweck danielweck mentioned this pull request Jul 31, 2025
Closed
@codebytere codebytere force-pushed the fix-video-playback-scrubbing branch from b9ac1c4 to 2048ae8 Compare July 31, 2025 09:41
@codebytere codebytere requested a review from deepak1556 July 31, 2025 09:41
deepak1556
deepak1556 approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielweck
Copy link

MacOS AppleSilicon arm64 tests fail after 6h CI runtime between:

1694 "iframe using HTML fullscreen API while window is OS-fullscreened can fullscreen from in-process iframes"
and
1695 "navigator.serial does not return a port if select-serial-port event is not defined"

...is that blocking this PR merge?

@codebytere codebytere force-pushed the fix-video-playback-scrubbing branch from 2048ae8 to 8b868b0 Compare August 1, 2025 13:51
@codebytere codebytere force-pushed the fix-video-playback-scrubbing branch from 8b868b0 to c0408a4 Compare August 1, 2025 20:27
@codebytere codebytere merged commit 678fb40 into main Aug 5, 2025
56 checks passed
@codebytere codebytere deleted the fix-video-playback-scrubbing branch August 5, 2025 16:48
@release-clerk
Copy link

release-clerk bot commented Aug 5, 2025

Release Notes Persisted

Fixed an issue where video scrubbing would not correctly hold the new position on playback.

@trop
Copy link
Contributor

trop bot commented Aug 5, 2025

I was unable to backport this PR to "37-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/37-x-y and removed target/37-x-y PR should also be added to the "37-x-y" branch. labels Aug 5, 2025
@trop trop bot mentioned this pull request Aug 5, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Aug 5, 2025

I have automatically backported this PR to "38-x-y", please check out #47965

@trop trop bot added in-flight/38-x-y and removed target/38-x-y PR should also be added to the "38-x-y" branch. labels Aug 5, 2025
@danielweck
Copy link

I was unable to backport this PR to "37-x-y" cleanly;
you will need to perform this backport manually.

thank you to whoever is going to do this :)

@trop trop bot added merged/38-x-y PR was merged to the "38-x-y" branch. and removed in-flight/38-x-y labels Aug 5, 2025
VerteDinde added a commit that referenced this pull request Aug 5, 2025
@VerteDinde @codebytere
fix: video scrubbing on playback (#47703)
9ce3118 
* fix: fix video scrubbing on playback

* chore: address review feedback

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@VerteDinde VerteDinde mentioned this pull request Aug 5, 2025
Merged
@trop
Copy link
Contributor

trop bot commented Aug 5, 2025

@VerteDinde has manually backported this PR to "37-x-y", please check out #47971

VerteDinde added a commit that referenced this pull request Aug 6, 2025
@VerteDinde @codebytere
fix: video scrubbing on playback (#47971)
3a493bc 
fix: video scrubbing on playback (#47703)

* fix: fix video scrubbing on playback

* chore: address review feedback

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot added merged/37-x-y PR was merged to the "37-x-y" branch. and removed in-flight/37-x-y labels Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't scrub the video served over protocol handler
5 participants
@VerteDinde @danielweck @codebytere @deepak1556 @dsanders11