fix: default to system accent color on invalid user color #47660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Jul 7, 2025
89a68f8 to
fe68bfe
Compare
deepak1556
approved these changes
Jul 7, 2025
|
Release Notes Persisted
|
|
I was unable to backport this PR to "36-x-y" cleanly; |
|
I was unable to backport this PR to "37-x-y" cleanly; |
|
I have automatically backported this PR to "38-x-y", please check out #47684 |
codebytere
added a commit
that referenced
this pull request
Jul 11, 2025
fix: default to system accent color on invalid user color"
|
@codebytere has manually backported this PR to "37-x-y", please check out #47800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes an issue where an invalid color passed as a string to
accentColorwould result in a white accent color. This happened because ourParseCSSColorutility falls back to white on parse failure. When a user passes an invalid string we should instead fall back to system color.This fixes that by reworking our
ParseCSSColorutility to return an optional value and leaving it up to the callers to decide their fallback color.cc @bpasero
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where an invalid color passed as a string to
accentColorwould result in a white accent color.