fix: fix and enable accessibilitySupportEnabled tests
#46825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
requested changes
Apr 28, 2025
Base automatically changed from
fix/enable-autoHideMenuBar-tests
to
test/fix-some-accidentally-disabled-tests
April 28, 2025 14:31
That feature is supported on Linux, so move the test from the "window states (excluding Linux)" section into the "window states" section.
test: check both getters after calling each setter fix: do not assume the default initial value of accessibilitySupportEnabled
c095185 to
7c62103
Compare
jkleinsc
approved these changes
Apr 28, 2025
|
No Release Notes |
|
I was unable to backport this PR to "35-x-y" cleanly; |
|
I was unable to backport this PR to "36-x-y" cleanly; |
|
I was unable to backport this PR to "34-x-y" cleanly; |
ckerr
added a commit
that referenced
this pull request
May 22, 2025
* test: enable accessibilitySupportEnabled tests * test: check both getters after calling each setter * fix: do not assume the default initial value of accessibilitySupportEnabled * chore: remove redundant test case * chore: disable accessibilitySupportEnabled tests on Linux
jkleinsc
pushed a commit
that referenced
this pull request
May 23, 2025
) fix: fix and enable `accessibilitySupportEnabled` tests (#46825) * test: enable accessibilitySupportEnabled tests * test: check both getters after calling each setter * fix: do not assume the default initial value of accessibilitySupportEnabled * chore: remove redundant test case * chore: disable accessibilitySupportEnabled tests on Linux
Closed
3 tasks
|
Regression in v37: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Part 4 in a series to enable/fix tests that didn't run due to #46807. This one fixes the
accessibilitySupportEnabledtests:Checklist
npm testpassesRelease Notes
Notes: none.