Skip to content

Conversation

codebytere
Copy link
Member

Description of Change

Closes #38466

Extends #39708 to fix an issue where the backgroundMaterial feature did not work in a frameless window on initial window creation. A repaint needed to be triggered first, by a resize or other similar action.

Checklist

Release Notes

Notes: Fixed an issue where the backgroundMaterial feature did not work in a frameless window on initial window creation.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. labels Apr 16, 2025
@codebytere codebytere requested a review from a team as a code owner April 16, 2025 16:30
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 16, 2025
@codebytere codebytere changed the title fix: backgroundMaterial on initial activate fix: backgroundMaterial on initial activate Apr 16, 2025
…atch

Co-authored-by: Charles Kerr <charles@charleskerr.com>
@codebytere codebytere force-pushed the fix-frameless-acrylic-initial-state branch from 7a9f916 to 32561d9 Compare April 17, 2025 07:55
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 17, 2025
@codebytere codebytere merged commit 4375427 into main Apr 17, 2025
56 checks passed
@codebytere codebytere deleted the fix-frameless-acrylic-initial-state branch April 17, 2025 18:34
@release-clerk
Copy link

release-clerk bot commented Apr 17, 2025

Release Notes Persisted

Fixed an issue where the backgroundMaterial feature did not work in a frameless window on initial window creation.

@trop
Copy link
Contributor

trop bot commented Apr 17, 2025

I was unable to backport this PR to "35-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 17, 2025

I was unable to backport this PR to "36-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/35-x-y needs-manual-bp/36-x-y and removed target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. labels Apr 17, 2025
ckerr pushed a commit that referenced this pull request Apr 25, 2025
@trop

This comment was marked as outdated.

@trop trop bot added the in-flight/main label Apr 25, 2025
@trop
Copy link
Contributor

trop bot commented Apr 25, 2025

@ckerr has manually backported this PR to "36-x-y", please check out #46792

ckerr added a commit that referenced this pull request Apr 26, 2025
* fix: `backgroundMaterial` on initial activate (#46657)

* empty commit

---------

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot added merged/36-x-y PR was merged to the "36-x-y" branch. and removed in-flight/36-x-y labels Apr 26, 2025
@trop
Copy link
Contributor

trop bot commented May 22, 2025

@ckerr has manually backported this PR to "35-x-y", please check out #47236

@trop trop bot added in-flight/35-x-y merged/35-x-y PR was merged to the "35-x-y" branch. and removed needs-manual-bp/35-x-y in-flight/35-x-y labels May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'backgroundMaterial' is not work in frameless window
3 participants