-
Notifications
You must be signed in to change notification settings - Fork 16.4k
fix: window maximizing with Mica #45456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ccaadd
to
682b69c
Compare
682b69c
to
76af7e4
Compare
43516c4
to
4696afe
Compare
76af7e4
to
7f35f36
Compare
When testing on Windows, the window no longer turns black, but the rounded corners are still not restored |
@mlaurencin try now, fixed in 54c1726 |
Great! Works for me now. Also I was able to build on x64 locally, so the build job for that might just need to rerun |
54c1726
to
d351d04
Compare
d351d04
to
8794a25
Compare
Release Notes Persisted
|
I was unable to backport this PR to "33-x-y" cleanly; |
I have automatically backported this PR to "35-x-y", please check out #45525 |
I have automatically backported this PR to "34-x-y", please check out #45526 |
This seems still a workaround to me because the animated resizing seems missing, and this is actually a "manual maximizing". The resizing animation seems needs WS_THICKFRAME to be working, but this patch disable it when maximizing. My previous observation make me wonder if Chromium's window is actually an child window of actual app window, while a typical WPF/WinUI app seems directly apply these styles on app window. Anyway, it is a progress 👍🏻 |
@codebytere , I'm testing v34.2.0 with a browser window with the following configuration: {
titleBarStyle: 'hidden',
titleBarOverlay: true,
backgroundMaterial: 'auto'
} If I maximize the window by pressing the maximize overlay button, it works fine (apart from the lack of animation which was already mentioned). If I maximize the window by double-clicking the draggable region of the window ( |
@eliandoran There's issue #46753 now. If you see additional incorrect behavior besides the issue that I linked, please file a new issue. (In general, comments on merged PRs often gets lost. Issues generally don't.) |
Description of Change
Closes #41824
Depends on #45422.
Refs #39708.
This PR mitigates an issue where the window lost its
backgroundMaterial
effects on maximization - turning black and losing its rounded corners. This happened in part because we made changes in an earlier PR to set transparency for correct Mica/Acrylic visuals, but didn't take into account that we'd then need to treat it in the special ways we treat transparent windows on Windows beyond that. This PR addresses those issues by expanding transparent handling to includebackgroundMaterial
translucency.This PR comes at cost of losing the smooth window animation, which is something I'm hopeful i can fix as a follow up. Our stock transparent window also has this issue.
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where windows on Windows with
backgroundMaterial
lost effect on maximization.