Use const for requires
#4109
Merged
Use const for requires
#4109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var slice = [].slice; | ||
|
|
||
| var appPath; |
There was a problem hiding this comment.
I think this was the first file we worked on, do we want to inline these now like we ended up doing in the other files?
There was a problem hiding this comment.
oh yeah, I'll do that 👍
| for (i = 0, len = ref1.length; i < len; i++) { | ||
| name = ref1[i]; | ||
| var name = ref1[i]; |
There was a problem hiding this comment.
The var deceleration should be outside of the loop (line 63).
| @@ -164,8 +162,9 @@ module.exports = { | |||
| }; | |||
|
|
|||
| // Mark standard asynchronous functions. | |||
| ref1 = ['showMessageBox', 'showOpenDialog', 'showSaveDialog']; | |||
| var ref1 = ['showMessageBox', 'showOpenDialog', 'showSaveDialog']; | |||
| var j, len | |||
There was a problem hiding this comment.
Super minor, but missing a ; here
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also inlined a few vars that coffee had listed at the top of each file.
A part of #4065