Skip to content

fix: frameless mica/acrylic windows #39708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 11, 2023
Merged

fix: frameless mica/acrylic windows #39708

merged 7 commits into from
Sep 11, 2023

Conversation

clavin
Copy link
Member

@clavin clavin commented Sep 1, 2023 •
edited
Loading

Description of Change

  • Adds a patch that lets frameless, translucent windows (i.e. mica, acryllic windows) become "activated", which is necessary for their effects
  • Automatically makes windows created with vibrancy/translucency effects have transparent background colors
  • Removes some caption styling on translucent window effects on Windows when setting background material

Fixes #38532

Checklist

Release Notes

Notes: Fixed Windows Mica/Acrylic background material effects on frameless windows.

@clavin clavin requested a review from a team as a code owner September 1, 2023 03:11
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 1, 2023
@clavin clavin added target/27-x-y PR should also be added to the "27-x-y" branch. semver/patch backwards-compatible bug fixes labels Sep 5, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 6, 2023
zcbenz
zcbenz approved these changes Sep 7, 2023
View reviewed changes
patches/chromium/fix_activate_background_material_on_windows.patch
with translucent background materials to become activated.

This patch likely can't be upstreamed as-is, as Chromium doesn't have
this use case in mind currently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for a simple patch like this there is a chance upstreaming it, read the change log of the file and find the maintainer who has done related modifications, and ask them to review.

VerteDinde
VerteDinde approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on Windows - the transparency seems to be working as expected. I'm also fine merging this as is and potentially upstreaming the patch later

@codebytere codebytere merged commit d182794 into main Sep 11, 2023
@codebytere codebytere deleted the clavin/frameless-bg-mat branch September 11, 2023 12:51
@release-clerk
Copy link

release-clerk bot commented Sep 11, 2023 •
edited by ckerr
Loading

Release Notes Persisted

Fixed Windows Mica / Acrylic background material effects on frameless windows.

@trop trop bot mentioned this pull request Sep 11, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Sep 11, 2023

I have automatically backported this PR to "27-x-y", please check out #39802

@trop trop bot added in-flight/27-x-y merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/27-x-y PR should also be added to the "27-x-y" branch. in-flight/27-x-y labels Sep 11, 2023
@codebytere codebytere mentioned this pull request Sep 21, 2023
Closed
3 tasks
@fzf404
Copy link

fzf404 commented Sep 21, 2023

Great, I hope to merge into Electron 26 soon.

@michalzaq12
Copy link
Contributor

@clavin #39959

@samuelmaddock samuelmaddock mentioned this pull request Sep 28, 2023
Closed
3 tasks
@JellyBrick JellyBrick mentioned this pull request Sep 30, 2023
Closed
@VerteDinde VerteDinde mentioned this pull request Oct 5, 2023
Merged
5 tasks
@brhenrique brhenrique mentioned this pull request Oct 31, 2023
Closed
5 tasks
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@clavin
fix: frameless mica/acrylic windows (electron#39708)
8e227dc 
* fix: backgroundMaterial works with frameless

* TODO: fix frameless mica/acrylic windows

* update caption color appropriately

* set background color properly

* refactor translucency method

* actualization
@brhenrique brhenrique mentioned this pull request Dec 12, 2023
Merged
5 tasks
@codebytere codebytere mentioned this pull request Feb 4, 2025
Merged
3 tasks
@codebytere codebytere mentioned this pull request Apr 16, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
merged/27-x-y PR was merged to the "27-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support full frame transparency with Mica background material
8 participants
@clavin @fzf404 @michalzaq12 @jkleinsc @zcbenz @samuelmaddock @VerteDinde @codebytere