fix: promise resolved to early when browser initiated in-page navigation v2 #39597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codebytere I reintroduced fix for loadURL promise, but somehow linux and mac build are failing. Can you paste me details about these failed tests because I don't have access to CircleCI. Thanks |
|
@TomaszMa You should be able to login to CircleCI with your GitHub account. |
|
The failing tests seem to be unrelated to this PR, I have restarted the CI tests. |
zcbenz
approved these changes
Aug 28, 2023
jkleinsc
approved these changes
Aug 28, 2023
|
Release Notes Persisted
|
|
I have automatically backported this PR to "25-x-y", please check out #39678 |
|
I have automatically backported this PR to "26-x-y", please check out #39679 |
|
I have automatically backported this PR to "27-x-y", please check out #39680 |
3 tasks
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce fix for loadURL promise resolved to early when browser initiated in-page navigation.
Fix was revered because test which was added in original PR was failing on linux. Now test is fixed.
Original PR: #39260
Revert PR: #39481
Description of Change
Checklist
npm testpassesRelease Notes
Notes: Fix problem with promise resolved to early when browser initiated in-page navigation.