feat: Add data parameter to app.requestSingleInstanceLock()
#30891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e28a18d to
aaeb805
Compare
|
This PR requires review from @electron/wg-upgrades |
jkleinsc
requested changes
Sep 27, 2021
deepak1556
reviewed
Sep 27, 2021
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
deepak1556
reviewed
Sep 28, 2021
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Outdated
Show resolved
Hide resolved
deepak1556
approved these changes
Oct 6, 2021
|
@jkleinsc windows ci patch failure seems weird, I am unable to repro it locally. Any idea whats happening there ? |
62f1e14 to
0458026
Compare
jkleinsc
approved these changes
Oct 11, 2021
|
API LGTM |
|
Merging as CI failures are flake unrelated to PR. |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "15-x-y" cleanly; |
|
I have automatically backported this PR to "16-x-y", please check out #31444 |
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
…on#30891) * WIP * Use serialization * Rebase windows impl of new app requestSingleInstanceLock parameter * Fix test * Implement posix side * Add backwards compatibility test * Apply PR feedback Windows * Fix posix impl * Switch mac impl back to vector * Refactor Windows impl * Use vectors, inline make_span * Use blink converter * fix: ownership across sequences * Fix upstream merge from Chromium Co-authored-by: deepak1556 <hop2deep@gmail.com>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 27, 2021
…on#30891) * WIP * Use serialization * Rebase windows impl of new app requestSingleInstanceLock parameter * Fix test * Implement posix side * Add backwards compatibility test * Apply PR feedback Windows * Fix posix impl * Switch mac impl back to vector * Refactor Windows impl * Use vectors, inline make_span * Use blink converter * fix: ownership across sequences * Fix upstream merge from Chromium Co-authored-by: deepak1556 <hop2deep@gmail.com>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
…on#30891) * WIP * Use serialization * Rebase windows impl of new app requestSingleInstanceLock parameter * Fix test * Implement posix side * Add backwards compatibility test * Apply PR feedback Windows * Fix posix impl * Switch mac impl back to vector * Refactor Windows impl * Use vectors, inline make_span * Use blink converter * fix: ownership across sequences * Fix upstream merge from Chromium Co-authored-by: deepak1556 <hop2deep@gmail.com>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
…on#30891) * WIP * Use serialization * Rebase windows impl of new app requestSingleInstanceLock parameter * Fix test * Implement posix side * Add backwards compatibility test * Apply PR feedback Windows * Fix posix impl * Switch mac impl back to vector * Refactor Windows impl * Use vectors, inline make_span * Use blink converter * fix: ownership across sequences * Fix upstream merge from Chromium Co-authored-by: deepak1556 <hop2deep@gmail.com>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
…on#30891) * WIP * Use serialization * Rebase windows impl of new app requestSingleInstanceLock parameter * Fix test * Implement posix side * Add backwards compatibility test * Apply PR feedback Windows * Fix posix impl * Switch mac impl back to vector * Refactor Windows impl * Use vectors, inline make_span * Use blink converter * fix: ownership across sequences * Fix upstream merge from Chromium Co-authored-by: deepak1556 <hop2deep@gmail.com>
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Oct 29, 2021
…on#30891) * WIP * Use serialization * Rebase windows impl of new app requestSingleInstanceLock parameter * Fix test * Implement posix side * Add backwards compatibility test * Apply PR feedback Windows * Fix posix impl * Switch mac impl back to vector * Refactor Windows impl * Use vectors, inline make_span * Use blink converter * fix: ownership across sequences * Fix upstream merge from Chromium Co-authored-by: deepak1556 <hop2deep@gmail.com>
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #18434
Fixes #23220
Affects microsoft/vscode#97626
This PR adds a new parameter to
app.requestSingleInstanceLock()which takes in a JSON object. When a second instance is started and calls that API with an object, the object will be sent from the second instance to the first instance.CC @deepak1556
Checklist
npm testpassesRelease Notes
Notes: add new data parameter to
app.requestSingleInstanceLock()