Skip to content

fix: get subframes directly rather than from main frame #29763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: get subframes directly rather than from main frame #29763

wants to merge 1 commit into from

Conversation

georgexu99
Copy link
Contributor

@georgexu99 georgexu99 commented Jun 17, 2021 •
edited
Loading

Backport of #29241

See that PR for more details

Notes: none

@rzhao271
fix: get subframes directly rather than from main frame (electron#29241)
3c38b6f 
* Get subframes directly rather than from main frame

* Add parent frame check
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 17, 2021
@trop trop bot mentioned this pull request Jun 17, 2021
Merged
5 tasks
@trop trop bot added 13-x-y backport This is a backport PR labels Jun 17, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 17, 2021
@VerteDinde VerteDinde self-requested a review June 17, 2021 21:18
@georgexu99 georgexu99 closed this Jun 17, 2021
@georgexu99 georgexu99 deleted the 13-x-y-robo/robo_find_in_frame branch June 17, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

Assignees
No one assigned
Labels
13-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgexu99 @rzhao271