fix: escape URL passed to shell.openExternal on windows #28334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Mar 22, 2021
4c943f7 to
14f4b51
Compare
nornagon
approved these changes
Mar 22, 2021
|
Release Notes Persisted
|
|
I have automatically backported this PR to "10-x-y", please check out #28339 |
This was referenced Mar 22, 2021
|
I have automatically backported this PR to "11-x-y", please check out #28340 |
|
I have automatically backported this PR to "12-x-y", please check out #28341 |
|
I have automatically backported this PR to "13-x-y", please check out #28342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns our
openExternalbehavior with upstream where the URL should be escaped before being sent to the external handler. Most applications expect a spec-compliant URI, this ensures they receive one.Notes: URLS passed to
shell.openExternalon windows are now correctly URI encoded. This was already occurring on macOS and Linux.