Skip to content

chore: add unit tests for findInPage/findInFrame #28330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2021
Merged

chore: add unit tests for findInPage/findInFrame #28330

merged 1 commit into from
Mar 22, 2021

Conversation

rzhao271
Copy link
Contributor

Description of Change

Adds tests to @deepak1556's findInFrame/stopFindInFrame API. Also adds some tests to findInPage for webContents.

CC @deepak1556

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 22, 2021
@rzhao271 rzhao271 marked this pull request as ready for review March 22, 2021 18:58
@deepak1556 deepak1556 merged commit 73d1b28 into electron:robo/find_in_frame Mar 22, 2021
@release-clerk
Copy link

release-clerk bot commented Mar 22, 2021

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-pr 🌱 PR opened recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzhao271 @deepak1556