Skip to content

fix: bad menu position when no positioning item specified #28276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2021
Merged

fix: bad menu position when no positioning item specified #28276

merged 1 commit into from
Mar 19, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 18, 2021

Backport of #28224

See that PR for details.

Notes: Fixed context menus not being positioned correctly when near the edge of the screen.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 18, 2021
@trop trop bot requested a review from nornagon March 18, 2021 20:38
@trop trop bot mentioned this pull request Mar 18, 2021
Merged
4 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 18, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 18, 2021
@zcbenz zcbenz merged commit 5f07df4 into 13-x-y Mar 19, 2021
@release-clerk
Copy link

release-clerk bot commented Mar 19, 2021

Release Notes Persisted

Fixed context menus not being positioned correctly when near the edge of the screen.

@trop trop bot deleted the trop/13-x-y-bp-fix-bad-menu-position-when-no-positioning-item-specified-1616099906114 branch March 19, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nornagon @zcbenz