fix: drag region offsets in BrowserViews #28268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
Mar 18, 2021
159a14a to
8ee1165
Compare
nornagon
approved these changes
Mar 18, 2021
MarshallOfSound
approved these changes
Mar 18, 2021
|
Test failures not related. |
|
Release Notes Persisted
|
This was referenced Mar 19, 2021
|
I have automatically backported this PR to "10-x-y", please check out #28295 |
|
I have automatically backported this PR to "12-x-y", please check out #28296 |
|
I have automatically backported this PR to "11-x-y", please check out #28297 |
|
I have automatically backported this PR to "13-x-y", please check out #28298 |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #28228.
Our y-axis offset calculation was slightly off - this corrects that.
Tested with https://gist.github.com/c138020abbb7d949608c3c11b1cad253 and also with https://gist.github.com/08f3e56e0a4dc443621bd769e18c7cd6 to ensure no regressions.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where the drag regions in BrowserViews on macOS could be off in their y-axis.