Skip to content

fix: revert "refactor: mmap asar files (#24470)" #28137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2021
Merged

fix: revert "refactor: mmap asar files (#24470)" #28137

merged 1 commit into from
Mar 15, 2021

Conversation

nornagon
Copy link
Contributor

@nornagon nornagon commented Mar 11, 2021 •
edited by codebytere
Loading

This reverts commit 01a2e23.

Fixes #27982.
Fixes #28195.

We should figure out a way to get the mmap code working, but in the mean time
this should solve the issue.

Checklist

Release Notes

Notes: Fixed intensive I/O from asar files causing ERR_FILE_NOT_FOUND after a while.

@nornagon nornagon added semver/patch backwards-compatible bug fixes target/11-x-y labels Mar 11, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 11, 2021
@nornagon nornagon mentioned this pull request Mar 11, 2021
Closed
3 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 12, 2021
@nomagick
Copy link

Well this may also fix #28195.

@nornagon nornagon merged commit d27ad0d into master Mar 15, 2021
@release-clerk
Copy link

release-clerk bot commented Mar 15, 2021

Release Notes Persisted

Fixed intensive I/O from asar files causing ERR_FILE_NOT_FOUND after a while.

@nornagon nornagon deleted the revert-mmap-asar branch March 15, 2021 18:43
This was referenced Mar 15, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Mar 15, 2021

I have automatically backported this PR to "11-x-y", please check out #28201

@trop trop bot removed the target/11-x-y label Mar 15, 2021
@trop
Copy link
Contributor

trop bot commented Mar 15, 2021

I have automatically backported this PR to "12-x-y", please check out #28202

@trop
Copy link
Contributor

trop bot commented Mar 15, 2021

I have automatically backported this PR to "13-x-y", please check out #28203

mlaurencin pushed a commit that referenced this pull request Mar 18, 2021
@nornagon @mlaurencin
fix: revert "refactor: mmap asar files (#24470)" (#28137)
45e34e5 
This reverts commit 01a2e23.
@nomagick nomagick mentioned this pull request Mar 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASAR fd not closeable on Windows Unable to read files from asar after 10+ hours of runtime
4 participants
@nornagon @nomagick @zcbenz @codebytere