fix: convert system colors to device color space in systemPreferences #28121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Mar 11, 2021
codebytere
approved these changes
Mar 12, 2021
|
Release Notes Persisted
|
|
I have automatically backported this PR to "11-x-y", please check out #28171 |
|
I have automatically backported this PR to "12-x-y", please check out #28172 |
|
I have automatically backported this PR to "13-x-y", please check out #28173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27048
There's a helpful
skiautil for doing this so it's not too bad in the end. Diving down the rabbit hole that is our color related APIs at the moment. I'll be raising the transparency (missing alpha channel) issue with the API WG soon for discussion 👍Notes: Colors returned from
systemPreferences.getAccentColor(),getSystemColorandgetColorare now correctly converted into the devices color space. Previously the color would have been subtly incorrect.