fix: handle a nil backgroundColor in win.getBackgroundColor() #28120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Mar 11, 2021
|
test? |
codebytere
approved these changes
Mar 12, 2021
|
Release Notes Persisted
|
This was referenced Mar 15, 2021
|
I have automatically backported this PR to "11-x-y", please check out #28186 |
|
I have automatically backported this PR to "13-x-y", please check out #28187 |
|
I have automatically backported this PR to "12-x-y", please check out #28188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28104
[CALayer backgroundColor]isnilby default. When we are transparent and don't assign a background color this would crash inside the skia helperNotes: Fixed crash when calling
getBackgroundColoron a transparent window with no assigned background color.