Skip to content

chore: cherry-pick 1fe571a from node #28067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2021
Merged

chore: cherry-pick 1fe571a from node #28067

merged 1 commit into from
Mar 10, 2021

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Mar 9, 2021 •
edited
Loading

Description of Change

Fixes #28043

Backports nodejs/node#37000

Checklist

Release Notes

Notes: fix native module compilation with AsyncCleanupHooks on windows

@deepak1556 deepak1556 requested a review from a team as a code owner March 9, 2021 04:18
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 9, 2021
@jkleinsc jkleinsc added the semver/patch backwards-compatible bug fixes label Mar 9, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 10, 2021
@deepak1556
Copy link
Member Author

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit 102a374 into master Mar 10, 2021
@release-clerk
Copy link

release-clerk bot commented Mar 10, 2021

Release Notes Persisted

fix native module compilation with AsyncCleanupHooks on windows

@deepak1556 deepak1556 deleted the robo/fix_nm_compile_win branch March 10, 2021 19:44
This was referenced Mar 10, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Mar 10, 2021

I have automatically backported this PR to "11-x-y", please check out #28108

@trop trop bot removed the target/11-x-y label Mar 10, 2021
@trop
Copy link
Contributor

trop bot commented Mar 10, 2021

I have automatically backported this PR to "12-x-y", please check out #28109

@trop
Copy link
Contributor

trop bot commented Mar 10, 2021

I have automatically backported this PR to "13-x-y", please check out #28110

@trop trop bot removed the in-flight/12-x-y label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nornagon nornagon nornagon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native Node Modules for Electron 11 and above do not compile with async cleanup behavior
3 participants
@deepak1556 @nornagon @jkleinsc