Skip to content

fix: uv loop polling when render process reuse enabled #25924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

fix: uv loop polling when render process reuse enabled #25924

merged 1 commit into from
Oct 14, 2020

Conversation

codebytere
Copy link
Member

Backport of #25869.

See that PR for more details.

Notes: Fixed an issue where some Node.js module API calls hung in the renderer process after reloads when render process reuse was enabled.

@codebytere codebytere requested a review from a team October 13, 2020 17:19
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 13, 2020
@trop trop bot mentioned this pull request Oct 13, 2020
Merged
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Oct 13, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 13, 2020
@zcbenz zcbenz merged commit 13f319e into 9-x-y Oct 14, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 14, 2020

Release Notes Persisted

Fixed an issue where some Node.js module API calls hung in the renderer process after reloads when render process reuse was enabled.

@zcbenz zcbenz deleted the evt-loop-polling-9 branch October 14, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @ckerr @zcbenz