Skip to content

fix: delay emitting powerMonitor events on windows #25836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 27, 2020
Merged

fix: delay emitting powerMonitor events on windows #25836

merged 6 commits into from
Oct 27, 2020

Conversation

nornagon
Copy link
Contributor

@nornagon nornagon commented Oct 8, 2020

Description of Change

This delays emitting certain powerMonitor events on Windows to avoid entering V8 during a WndProc callback, which can cause crashes.

Checklist

Release Notes

Notes: Fixed a rare crash on Windows that could occur when emitting certain powerMonitor events.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 8, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 9, 2020
zcbenz
zcbenz suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing.

zcbenz
zcbenz reviewed Oct 15, 2020
View reviewed changes
@nornagon
Copy link
Contributor Author

@zcbenz should be fixed now.

@zcbenz zcbenz merged commit ae32356 into master Oct 27, 2020
@release-clerk
Copy link

release-clerk bot commented Oct 27, 2020

Release Notes Persisted

Fixed a rare crash on Windows that could occur when emitting certain powerMonitor events.

@zcbenz zcbenz deleted the delay-pm-events branch October 27, 2020 01:25
This was referenced Oct 27, 2020
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 27, 2020

I have automatically backported this PR to "10-x-y", please check out #26180

@trop
Copy link
Contributor

trop bot commented Oct 27, 2020

I have automatically backported this PR to "11-x-y", please check out #26181

@erickzhao erickzhao mentioned this pull request Nov 24, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nornagon @zcbenz @MarshallOfSound