Skip to content

fix: emit will-navigate for sandboxed contents (#22188) #22329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2020
Merged

fix: emit will-navigate for sandboxed contents (#22188) #22329

merged 4 commits into from
Feb 26, 2020

Conversation

nornagon
Copy link
Contributor

Backport of #22188.

Notes: Fixed "will-navigate" event not being emitted for sandboxed contents.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 21, 2020
@trop trop bot mentioned this pull request Feb 21, 2020
Merged
6 tasks
@trop trop bot added 7-1-x backport This is a backport PR labels Feb 21, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 21, 2020
@zcbenz
Copy link
Contributor

zcbenz commented Feb 25, 2020

Build is failing.

@zcbenz zcbenz merged commit dd242f4 into 7-1-x Feb 26, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 26, 2020

Release Notes Persisted

Fixed "will-navigate" event not being emitted for sandboxed contents.

@zcbenz zcbenz deleted the backport/7-1-x/sandbox-will-navigate branch February 26, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
7-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nornagon @zcbenz