Skip to content

fix: emit will-navigate for sandboxed contents (#22188) #22328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2020
Merged

fix: emit will-navigate for sandboxed contents (#22188) #22328

merged 1 commit into from
Feb 24, 2020

Conversation

nornagon
Copy link
Contributor

Backport of #22188.

Notes: Fixed "will-navigate" event not being emitted for sandboxed contents.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 21, 2020
@trop trop bot mentioned this pull request Feb 21, 2020
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Feb 21, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 21, 2020
@MarshallOfSound MarshallOfSound merged commit 4464a04 into 8-x-y Feb 24, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 24, 2020

Release Notes Persisted

Fixed "will-navigate" event not being emitted for sandboxed contents.

@MarshallOfSound MarshallOfSound deleted the backport/8-x-y/sandbox-will-navigate branch February 24, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nornagon @MarshallOfSound