Skip to content

fix: emit will-navigate for sandboxed contents #22327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 25, 2020
Merged

fix: emit will-navigate for sandboxed contents #22327

merged 7 commits into from
Feb 25, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 21, 2020

Backport of #22188

See that PR for details.

Notes: Fixed "will-navigate" event not being emitted for sandboxed contents.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 21, 2020
@trop trop bot requested a review from nornagon February 21, 2020 19:08
@trop trop bot mentioned this pull request Feb 21, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Feb 21, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 21, 2020
@zcbenz zcbenz merged commit 64880c7 into 9-x-y Feb 25, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 25, 2020

Release Notes Persisted

Fixed "will-navigate" event not being emitted for sandboxed contents.

@zcbenz zcbenz deleted the trop/9-x-y-bp-fix-emit-will-navigate-for-sandboxed-contents-1582312125587 branch February 25, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon Awaiting requested review from nornagon

1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @nornagon