Skip to content

fix: correctly crash when there is no crashReporter #20396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2019
Merged

fix: correctly crash when there is no crashReporter #20396

merged 2 commits into from
Oct 1, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 1, 2019

Backport of #20388

See that PR for details.

Notes: Fix process taking 100% CPU when crashed with no crashReporter set up on Windows x64.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 1, 2019
@trop trop bot mentioned this pull request Oct 1, 2019
Merged
6 tasks
@trop trop bot added 6-0-x backport This is a backport PR labels Oct 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 1, 2019
@jkleinsc jkleinsc merged commit e472efb into 6-0-x Oct 1, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 1, 2019

Release Notes Persisted

Fix process taking 100% CPU when crashed with no crashReporter set up on Windows x64.

@jkleinsc jkleinsc deleted the trop/6-0-x-bp-fix-correctly-crash-when-there-is-no-crashreporter-1569950437373 branch October 1, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @zcbenz