fix: correctly crash when there is no crashReporter #20388
Merged
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
Oct 1, 2019
jkleinsc
approved these changes
Oct 1, 2019
|
Merging as Windows 32 bit failure is known flake unrelated to this PR. |
|
Release Notes Persisted
|
This was referenced Oct 1, 2019
|
I have automatically backported this PR to "7-0-x", please check out #20395 |
|
I have automatically backported this PR to "6-0-x", please check out #20396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Close #20233.
When there is exception and we do not have crashReporter set up, we should let the execution continue and crash, which is the default behavior of Windows programs.
Checklist
npm testpassesRelease Notes
Notes: Fix process taking 100% CPU when crashed with no crashReporter set up on Windows x64.