fix: tray.displayBalloon() does not work with custom icon on Windows #19330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aa43366 to
ddf52bf
Compare
|
Which code did you use to test this? Doesn't seem to work for me 🤔 |
|
@deermichel just this snippet in Fiddle const icon = nativeImage.createFromPath('C:\\Windows\\WinSxS\\amd64_microsoft-windows-dxp-deviceexperience_31bf3856ad364e35_10.0.18362.1_none_19829bbf76ffad81\\ringtones.ico')
const tray = new Tray(icon)
tray.on('click', () => {
tray.displayBalloon({
title: 'Hello World!',
content: 'Lorem Ipsum',
icon
})
}) |
codebytere
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
approving in agreement with issue description and confirmation by @deermichel of change efficacy.
alexeykuzmin
approved these changes
Jul 30, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "6-0-x", please check out #19528 |
|
I have automatically backported this PR to "4-2-x", please check out #19529 |
|
I have automatically backported this PR to "5-0-x", please check out #19530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
According to the NIIF_LARGE_ICON documentation:
The other option would be to keep the
SM_CXSMICONsize, but to drop theNIIF_LARGE_ICONflag.Checklist
npm testpassesRelease Notes
Notes: Fixed
tray.displayBalloon()not working with custom icon on Windows.