Skip to content

Conversation

electron-bot
Copy link
Contributor

Updating Chromium to 76.0.3809.73.

See all changes in 76.0.3809.70..76.0.3809.73

Notes: Updated Chromium to 76.0.3809.73.

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit failure on macOS (looks like we're hitting a CHECK in webContents creation/navigation)

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted the Helper changes from the master roll --> #18648

@MarshallOfSound MarshallOfSound force-pushed the roller/chromium/6-0-x branch from 235a0de to 1a55bd2 Compare July 18, 2019 23:32
@MarshallOfSound MarshallOfSound force-pushed the roller/chromium/6-0-x branch from b6ba535 to 702ca8b Compare July 19, 2019 03:25
@MarshallOfSound MarshallOfSound merged commit 66c2bd2 into 6-0-x Jul 19, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 19, 2019

Release Notes Persisted

Updated Chromium to 76.0.3809.73.

@MarshallOfSound MarshallOfSound deleted the roller/chromium/6-0-x branch July 19, 2019 04:43
@nornagon
Copy link
Contributor

Looks like this is causing this CHECK() to fire, at least in Slack:
https://github.com/electron/electron/blame/v6.0.0-beta.15/atom/browser/atom_browser_client.cc#L497

@MarshallOfSound
Copy link
Member

@nornagon Let's talk offline, that CHECK won't fire if we're packaging the app correctly. (We need to package Electron Helper (Renderer).app and Electron Helper (Plugin).app as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants