Skip to content

fix: tray.displayBalloon() does not work with custom icon on Windows #19529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2019
Merged

fix: tray.displayBalloon() does not work with custom icon on Windows #19529

merged 1 commit into from
Jul 31, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 30, 2019

Backport of #19330

See that PR for details.

Notes: Fixed tray.displayBalloon() not working with custom icon on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 30, 2019
@trop trop bot mentioned this pull request Jul 30, 2019
Merged
5 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Jul 30, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 30, 2019
@MarshallOfSound MarshallOfSound merged commit 90173a0 into 4-2-x Jul 31, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 31, 2019

Release Notes Persisted

Fixed tray.displayBalloon() not working with custom icon on Windows.

@MarshallOfSound MarshallOfSound deleted the trop/4-2-x-bp-fix-tray-displayballoon-does-not-work-with-custom-icon-on-windows-1564488408291 branch July 31, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @MarshallOfSound @miniak