Fullscreen works fine, but there are some details missing.

Fullscreen enter/exit keyboard shortcuts don't work.

Electron should by default enter fullscreen on ⌃⌘F and exit on ⌃⌘F or Esc. This is the default behavior for other apps.

Enter fullscreen menu item

Many apps comes with a View => Enter Full Screen menu. There should be a menu role for this so it's handled automatically. This is important as the menu label needs to be Exit Full Screen when in fullscreen.

I want to be able to do:

{
        role: 'fullscreen'
}

In the menu template, and have label and accelerator handled for me: #2812.

Relevant: 2d940b7