Skip to content

ASAR fd not closeable on Windows #28195

@nomagick

Description

@nomagick

Preflight Checklist

Electron Version

12.0.0

What operating system are you using?

Windows

Operating System Version

Windows 10 version 1909

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

File unlocked after closing the renderer process that access the asar package.

Actual Behavior

File still locked after closing the renderer process that access the asar package.

Testcase Gist URL

No response

#24470 broke #4118 , #4129

Asar file not closed automatically on Windows.

In my project, multiple web apps were each packaged into asar archives and then load by Electron renderers.

It's also vital that these packages were able to be removed and replaced while Electron main process is running.

I found that this issue was fixed before (#4118 , #4129) but then broke by #24470, which also removed the getFD method, making this issue not likely to be walked-around without forking and recompiling.

May I suggest adding these features back?

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions